Re: [PATCH v2 1/1] Jobs based on custom runners: add CentOS Stream 8

2021-11-12 Thread Willian Rampazzo
; create mode 100755 scripts/ci/org.centos/stream/8/x86_64/test-avocado > create mode 100644 scripts/ci/org.centos/stream/README > Maybe it is too late, but just for the records: Reviewed-by: Willian Rampazzo Tested-by: Willian Rampazzo CI job on a custom VM runner: https://gitlab.com/willianrampazzo/qemu/-/jobs/1778451942

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Willian Rampazzo
On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy wrote: > > 9/30/21 11:47, Richard W.M. Jones wrote: > > Under SELinux, Unix domain sockets have two labels. One is on the > > disk and can be set with commands such as chcon(1). There is a > > different label stored in memory (called

Re: [PATCH] gitlab-ci.d/buildtest: Disable iotests 197 and 215

2021-07-27 Thread Willian Rampazzo
gned-off-by: Thomas Huth > --- > .gitlab-ci.d/buildtest.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 8/9] tests/acceptance: Remove now unused pow2ceil()

2021-07-05 Thread Willian Rampazzo
On Wed, Jun 23, 2021 at 3:10 PM Philippe Mathieu-Daudé wrote: > > We don't use pow2ceil() anymore, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/boot_linux_console.py | 12 > 1 file changed, 12 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [RFC PATCH 6/9] tests/acceptance: Use image_expand() in test_arm_orangepi_bionic_20_08

2021-07-05 Thread Willian Rampazzo
--- > tests/acceptance/boot_linux_console.py | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 5/9] tests/acceptance: Use image_expand() in test_arm_orangepi_uboot_netbsd9

2021-07-05 Thread Willian Rampazzo
9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 4/9] tests/acceptance: Extract image_expand() helper

2021-07-05 Thread Willian Rampazzo
4 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

2021-07-05 Thread Willian Rampazzo
hilippe Mathieu-Daudé > --- > tests/acceptance/boot_linux_console.py | 1 + > tests/acceptance/ppc_prep_40p.py | 2 ++ > 2 files changed, 3 insertions(+) > Reviewed-by: Willian Rampazzo

Re: [PATCH 2/4] Python QEMU utils: introduce a generic feature list

2021-06-10 Thread Willian Rampazzo
gt; 3 files changed, 48 insertions(+), 13 deletions(-) > create mode 100644 python/qemu/utils/feature.py > Based on my comments from the next patch of this series: Reviewed-by: Willian Rampazzo

Re: [PATCH 3/4] Acceptance Tests: introduce method to require a feature and option

2021-06-10 Thread Willian Rampazzo
ature is "machine", option can be "q35". > +type option: str > +""" > +try: > + options_available = list_feature(self.qemu_bin, feature) Looking at this code, the previous patch makes more sense the way it is now :) Maybe, splitting it into multiple `list_` functions will make the code here more complex. Anyway, I'll let you decide. Reviewed-by: Willian Rampazzo

Re: [PATCH 2/4] Python QEMU utils: introduce a generic feature list

2021-06-10 Thread Willian Rampazzo
On Tue, Jun 8, 2021 at 8:55 PM Cleber Rosa Junior wrote: > > > > On Tue, Jun 8, 2021 at 5:42 PM Wainer dos Santos Moschetta > wrote: >> >> Hi, >> >> On 6/8/21 11:09 AM, Cleber Rosa wrote: >> > Which can be used to check for any "feature" that is available as a >> > QEMU command line option, and

Re: [PATCH 4/4] Jobs based on custom runners: add CentOS Stream 8

2021-06-10 Thread Willian Rampazzo
On Tue, Jun 8, 2021 at 11:10 AM Cleber Rosa wrote: > > This introduces three different parts of a job designed to run > on a custom runner managed by Red Hat. The goals include: > > a) serve as a model for other organizations that want to onboard > their own runners, with their specific

Re: [PATCH 0/4] Jobs based on custom runners: add CentOS Stream 8

2021-06-10 Thread Willian Rampazzo
gh the formal method of tracking machine/job maintainers have > not been formalized, it should be known that the contacts/admins for > this machine and job are: > > - Cleber Rosa > >clebergnu on #qemu > > - Willian Rampazzo > >willianr on #qemu Acked-by: Willian Rampazzo

Re: [PATCH v6 03/25] python: create utils sub-package

2021-05-21 Thread Willian Rampazzo
| 2 +- > tests/vm/basevm.py| 3 ++- > 7 files changed, 29 insertions(+), 13 deletions(-) > create mode 100644 python/qemu/utils/__init__.py > rename python/qemu/{machine => utils}/accel.py (100%) > Reviewed-by: Willian Rampazzo

Re: [PATCH v6 02/25] python: create qemu packages

2021-05-21 Thread Willian Rampazzo
/.flake8 (100%) > create mode 100644 python/qemu/machine/__init__.py > rename python/qemu/{ => machine}/accel.py (100%) > rename python/qemu/{ => machine}/console_socket.py (100%) > rename python/qemu/{ => machine}/machine.py (98%) > rename python/qemu/{ => machine}/pylintrc (100%) > rename python/qemu/{ => machine}/qtest.py (99%) > rename python/qemu/{qmp.py => qmp/__init__.py} (96%) > This improves a lot the organization of the code. Reviewed-by: Willian Rampazzo

Re: [PATCH 4/4] iotests/297: Cover tests/

2021-03-29 Thread Willian Rampazzo
do not have to add anything to SKIP_FILES. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/297 | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 3/4] migrate-bitmaps-test: Fix pylint warnings

2021-03-29 Thread Willian Rampazzo
lways put two empty lines after a function > - f'exec: cat > /dev/null' does not need to be an f-string > > Fix them. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/tests/migrate-bitmaps-test | 38 ++- > 1 file changed, 20 insertions(+), 18 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings

2021-03-29 Thread Willian Rampazzo
est | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Willian Rampazzo

Re: [PATCH 1/4] iotests/297: Drop 169 and 199 from the skip list

2021-03-29 Thread Willian Rampazzo
/qemu-iotests/297 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v4 02/10] iotests/297: Rewrite in Python and extend reach

2021-02-08 Thread Willian Rampazzo
On 1/18/21 7:09 AM, Max Reitz wrote: On 15.01.21 20:27, Willian Rampazzo wrote: On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote: Instead of checking iotests.py only, check all Python files in the qemu-iotests/ directory.  Of course, most of them do not pass, so there is an extensive skip

Re: [PATCH v4 02/10] iotests/297: Rewrite in Python and extend reach

2021-01-15 Thread Willian Rampazzo
> +iotests.logger.debug('Files to be checked:') > +iotests.logger.debug(', '.join(sorted(files))) > + > +print('=== pylint ===') > +sys.stdout.flush() > + > +# Todo notes are fine, but fixme's or xxx's should probably just be > +# fixed (in tests, at least) > +env = os.environ.copy() > +try: > +env['PYTHONPATH'] += ':../../python/' Do you have any objection to using os.path.dirname and os.path.join here? This would make the code more pythonic. > +except KeyError: > +env['PYTHONPATH'] = '../../python/' Same here. You could do it once, before the 'try' and use it inside. Other than that, Reviewed-by: Willian Rampazzo

Re: [PATCH v4 01/10] iotests.py: Assume a couple of variables as given

2021-01-15 Thread Willian Rampazzo
this patch wants to prevent. > > Signed-off-by: Max Reitz > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/300| 1 - > tests/qemu-iotests/iotests.py | 26 +- > 2 files changed, 13 insertions(+), 14 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v4 03/10] iotests: Move try_remove to iotests.py

2021-01-15 Thread Willian Rampazzo
ged, 8 insertions(+), 11 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v4 05/10] iotests/129: Do not check @busy

2021-01-15 Thread Willian Rampazzo
> tests/qemu-iotests/129 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v4 06/10] iotests/129: Use throttle node

2021-01-15 Thread Willian Rampazzo
Reitz > Reviewed-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/129 | 37 + > 1 file changed, 13 insertions(+), 24 deletions(-) Reviewed-by: Willian Rampazzo

Re: [PATCH v4 07/10] iotests/129: Actually test a commit job

2021-01-15 Thread Willian Rampazzo
> --- > tests/qemu-iotests/129 | 27 +-- > 1 file changed, 25 insertions(+), 2 deletions(-) Reviewed-by: Willian Rampazzo

Re: [PATCH v4 10/10] iotests/300: Clean up pylint and mypy complaints

2021-01-15 Thread Willian Rampazzo
- > 2 files changed, 16 insertions(+), 4 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v3 08/10] iotests/129: Limit mirror job's buffer size

2021-01-15 Thread Willian Rampazzo
Ogievskiy > --- > tests/qemu-iotests/129 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH v3 04/10] iotests/129: Remove test images in tearDown()

2021-01-15 Thread Willian Rampazzo
On Thu, Jan 14, 2021 at 2:29 PM Max Reitz wrote: > > Signed-off-by: Max Reitz > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/129 | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Willian Rampazzo

Re: [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints

2021-01-15 Thread Willian Rampazzo
On Fri, Jan 15, 2021 at 6:30 AM Max Reitz wrote: > > On 14.01.21 21:02, Willian Rampazzo wrote: > > On Thu, Jan 14, 2021 at 2:41 PM Max Reitz wrote: > >> > >> Signed-off-by: Max Reitz > >> --- > >> tests/qemu-iotests/129 | 4 ++-- > >>

Re: [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints

2021-01-14 Thread Willian Rampazzo
part of mypy/pylint cleanup? It seems you are doing more than that here. It would be good to have this listed in the commit message. Despite that, Reviewed-by: Willian Rampazzo > '151', '152', '155', '163', '165', '169', '194', '196', '199', '202', > '203', '205', '206', '207', '208', '210', '211', '212', '213', '216', > '218', '219', '222', '224', '228', '234', '235', '236', '237', '238', > -- > 2.29.2 > >

Re: [RFC PATCH 5/5] tests/integration: Test Fuloong2E IDE drive, run userspace commands

2021-01-06 Thread Willian Rampazzo
console: / # reboot > console: / # umount: devtmpfs busy - remounted read-only > console: EXT4-fs (sda): re-mounted. Opts: (null) > console: The system is going down NOW! > console: Sent SIGTERM to all processes > console: Sent SIGKILL to all processes > console: Requesting system reboot > console: sd 0:0:0:0: [sda] Synchronizing SCSI cache > console: reboot: Restarting system > PASS (8.44 s) > RESULTS: PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | > CANCEL 0 > JOB TIME : 8.85 s > > [*] https://github.com/groeck/linux-build-test/ > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Guenter Roeck > --- > tests/acceptance/boot_linux_console.py | 30 -- > 1 file changed, 28 insertions(+), 2 deletions(-) > Reviewed-by: Willian Rampazzo