Re: [PATCH] block/backup: drop dead code from backup_job_create

2019-10-18 Thread Kevin Wolf
Am 17.10.2019 um 16:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > After commit 00e30f05de1d195, there is no more "goto error" points > after job creation, so after "error:" @job is always NULL and we don't > need roll-back job creation. > > Reported-by: Coverity (CID 1406402) >

Re: [PATCH] block/backup: drop dead code from backup_job_create

2019-10-18 Thread Stefano Garzarella
Hi Vladimir, On Thu, Oct 17, 2019 at 05:21:22PM +0300, Vladimir Sementsov-Ogievskiy wrote: > After commit 00e30f05de1d195, there is no more "goto error" points > after job creation, so after "error:" @job is always NULL and we don't > need roll-back job creation. I don't know this code very

[PATCH] block/backup: drop dead code from backup_job_create

2019-10-17 Thread Vladimir Sementsov-Ogievskiy
After commit 00e30f05de1d195, there is no more "goto error" points after job creation, so after "error:" @job is always NULL and we don't need roll-back job creation. Reported-by: Coverity (CID 1406402) Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 5 + 1 file changed, 1