Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-07 Thread John Snow
On 8/5/20 4:41 PM, Peter Maydell wrote: On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: The struct had a single field (IDEDevice dev), and is only used in the QOM type declarations and property lists. We can simply use the IDEDevice struct directly instead. Signed-off-by: Eduardo Habkost

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-06 Thread Peter Maydell
On Wed, 5 Aug 2020 at 23:14, Eduardo Habkost wrote: > On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: > > This is one of those areas where this change works and reduces > > amount of code, but on the other hand it means the QOM type > > doesn't follow the common pattern for a leaf t

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-06 Thread Daniel P . Berrangé
On Thu, Aug 06, 2020 at 07:58:06AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: > >> On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: > >> > > >> > The struct had a single field (IDEDevice dev), and is only used

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: >> On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: >> > >> > The struct had a single field (IDEDevice dev), and is only used >> > in the QOM type declarations and property lists. We can simply >> > use

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Eduardo Habkost
On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: > On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: > > > > The struct had a single field (IDEDevice dev), and is only used > > in the QOM type declarations and property lists. We can simply > > use the IDEDevice struct directly ins

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: > > The struct had a single field (IDEDevice dev), and is only used > in the QOM type declarations and property lists. We can simply > use the IDEDevice struct directly instead. > > Signed-off-by: Eduardo Habkost > @@ -327,7 +323,6 @@ static vo

[PATCH] ide: Get rid of IDEDrive struct

2020-08-05 Thread Eduardo Habkost
The struct had a single field (IDEDevice dev), and is only used in the QOM type declarations and property lists. We can simply use the IDEDevice struct directly instead. Signed-off-by: Eduardo Habkost --- hw/ide/qdev.c | 25 + 1 file changed, 9 insertions(+), 16 deletion