Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote: >> There are a number of unnecessary trailing whitespaces that have >> accumulated over time in the source code. They cause stray changes >> in patches if you use tools that automatically remove

Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-08 Thread Daniel P . Berrangé
ation: > > Subject: [PATCH] trivial: Remove trailing whitespaces > Type: series > Message-id: 20200706162300.1084753-1-dinec...@redhat.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 &g

Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-08 Thread Roman Bolshakov
On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote: > There are a number of unnecessary trailing whitespaces that have > accumulated over time in the source code. They cause stray changes > in patches if you use tools that automatically remove them. > > Tested by doing a `git

Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-07 Thread Daniel P . Berrangé
On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote: > There are a number of unnecessary trailing whitespaces that have > accumulated over time in the source code. They cause stray changes > in patches if you use tools that automatically remove them. > > Tested by doing a `git

Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-07 Thread Laurent Vivier
Le 06/07/2020 à 18:23, Christophe de Dinechin a écrit : > There are a number of unnecessary trailing whitespaces that have > accumulated over time in the source code. They cause stray changes > in patches if you use tools that automatically remove them. > > Tested by doing a `git diff -w` after

Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-07 Thread David Gibson
On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote: > There are a number of unnecessary trailing whitespaces that have > accumulated over time in the source code. They cause stray changes > in patches if you use tools that automatically remove them. > > Tested by doing a `git

Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200706162300.1084753-1-dinec...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] trivial: Remove trailing whitespaces Type: series Message-id: 20200706162300.1084753-1-dinec

[PATCH] trivial: Remove trailing whitespaces

2020-07-06 Thread Christophe de Dinechin
There are a number of unnecessary trailing whitespaces that have accumulated over time in the source code. They cause stray changes in patches if you use tools that automatically remove them. Tested by doing a `git diff -w` after the change. This could probably be turned into a pre-commit hook.