Re: [PATCH-for-9.0] hw/sd/sdhci: Discard excess of data written to Buffer Data Port register

2024-04-09 Thread Philippe Mathieu-Daudé
On 9/4/24 13:35, Peter Maydell wrote: On Mon, 8 Apr 2024 at 17:42, Peter Maydell wrote: So another approach here would be... That said, this is all quite complicated looking, so for 9.0 and backports at least this patch is fine. Your patch looks like the correct fix, and doesn't seem that

Re: [PATCH-for-9.0] hw/sd/sdhci: Discard excess of data written to Buffer Data Port register

2024-04-09 Thread Peter Maydell
On Mon, 8 Apr 2024 at 17:42, Peter Maydell wrote: > So another approach here would be... That said, this is all quite complicated looking, so for 9.0 and backports at least this patch is fine. Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH-for-9.0] hw/sd/sdhci: Discard excess of data written to Buffer Data Port register

2024-04-08 Thread Peter Maydell
On Mon, 8 Apr 2024 at 13:34, Peter Maydell wrote: > > On Thu, 4 Apr 2024 at 09:56, Philippe Mathieu-Daudé wrote: > > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c > > index c5e0bc018b..2dd88fa139 100644 > > --- a/hw/sd/sdhci.c > > +++ b/hw/sd/sdhci.c > > @@ -552,7 +552,7 @@ static void

Re: [PATCH-for-9.0] hw/sd/sdhci: Discard excess of data written to Buffer Data Port register

2024-04-08 Thread Peter Maydell
On Thu, 4 Apr 2024 at 09:56, Philippe Mathieu-Daudé wrote: > > Per "SD Host Controller Standard Specification Version 3.00": > > * 1.7 Buffer Control > > - 1.7.1 Control of Buffer Pointer > > (3) Buffer Control with Block Size > > In case of write operation, the buffer accumulates the

Re: [PATCH-for-9.0] hw/sd/sdhci: Discard excess of data written to Buffer Data Port register

2024-04-08 Thread Mauro Matteo Cascella
On Thu, Apr 4, 2024 at 10:55 AM Philippe Mathieu-Daudé wrote: > > Per "SD Host Controller Standard Specification Version 3.00": > > * 1.7 Buffer Control > > - 1.7.1 Control of Buffer Pointer > > (3) Buffer Control with Block Size > > In case of write operation, the buffer accumulates

[PATCH-for-9.0] hw/sd/sdhci: Discard excess of data written to Buffer Data Port register

2024-04-04 Thread Philippe Mathieu-Daudé
Per "SD Host Controller Standard Specification Version 3.00": * 1.7 Buffer Control - 1.7.1 Control of Buffer Pointer (3) Buffer Control with Block Size In case of write operation, the buffer accumulates the data written through the Buffer Data Port register. When the buffer