Re: [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps

2019-10-09 Thread Vladimir Sementsov-Ogievskiy
09.10.2019 23:44, John Snow wrote: > > > On 10/9/19 2:57 PM, Eric Blake wrote: >> On 6/6/19 1:41 PM, John Snow wrote: >>> When adding new persistent dirty bitmaps, we only check constraints >>> against currently stored bitmaps, and ignore the pending number and size >>> of any bitmaps yet to be s

Re: [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps

2019-10-09 Thread John Snow
On 10/9/19 2:57 PM, Eric Blake wrote: > On 6/6/19 1:41 PM, John Snow wrote: >> When adding new persistent dirty bitmaps, we only check constraints >> against currently stored bitmaps, and ignore the pending number and size >> of any bitmaps yet to be stored. >> >> Rework the "can_store" and "rem

Re: [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps

2019-10-09 Thread Eric Blake
On 6/6/19 1:41 PM, John Snow wrote: When adding new persistent dirty bitmaps, we only check constraints against currently stored bitmaps, and ignore the pending number and size of any bitmaps yet to be stored. Rework the "can_store" and "remove" interface to explicit "add" and "remove", and begi

Re: [Qemu-block] [Qemu-devel] [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps

2019-06-06 Thread John Snow
devel] [PATCH 0/5] block/dirty-bitmap: check number and size > constraints against queued bitmaps > Type: series > Message-id: 20190606184159.979-1-js...@redhat.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local

Re: [Qemu-block] [Qemu-devel] [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps

2019-06-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190606184159.979-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps Type

[Qemu-block] [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps

2019-06-06 Thread John Snow
When adding new persistent dirty bitmaps, we only check constraints against currently stored bitmaps, and ignore the pending number and size of any bitmaps yet to be stored. Rework the "can_store" and "remove" interface to explicit "add" and "remove", and begin keeping track of the queued burden w