Re: [PATCH 03/21] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts

On 9/15/23 20:41, Denis V. Lunev wrote: This patch creates above mentioned helper and moves its usage to the beginning of parallels_open(). This simplifies parallels_open() a bit. The patch also ensures that we store prealloc_size on block driver state always in sectors. This makes code cleaner

Re: [PATCH 03/21] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts

On 9/17/23 13:40, Mike Maslenkin wrote: This is not introduced by this patch, but looks like qemu_opts_del(opts) missed. nice spot! On Fri, Sep 15, 2023 at 9:41 PM Denis V. Lunev wrote: This patch creates above mentioned helper and moves its usage to the beginning of parallels_open(). This

Re: [PATCH 03/21] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts

This is not introduced by this patch, but looks like qemu_opts_del(opts) missed. On Fri, Sep 15, 2023 at 9:41 PM Denis V. Lunev wrote: > > This patch creates above mentioned helper and moves its usage to the > beginning of parallels_open(). This simplifies parallels_open() a bit. > > The patch

[PATCH 03/21] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts

This patch creates above mentioned helper and moves its usage to the beginning of parallels_open(). This simplifies parallels_open() a bit. The patch also ensures that we store prealloc_size on block driver state always in sectors. This makes code cleaner and avoids wrong opinion at the