Re: [PATCH 05/22] hw/sd: sd: Drop sd_crc16()

2021-01-14 Thread Philippe Mathieu-Daudé
On 12/31/20 12:29 PM, Bin Meng wrote: > From: Bin Meng > > commit f6fb1f9b319f ("sdcard: Correct CRC16 offset in sd_function_switch()") > changed the 16-bit CRC to be stored at offset 64. In fact, this CRC > calculation is completely wrong. Yeah:

Re: [PATCH 05/22] hw/sd: sd: Drop sd_crc16()

2021-01-02 Thread Pragnesh Patel
On Thu, Dec 31, 2020 at 5:04 PM Bin Meng wrote: > > From: Bin Meng > > commit f6fb1f9b319f ("sdcard: Correct CRC16 offset in sd_function_switch()") > changed the 16-bit CRC to be stored at offset 64. In fact, this CRC > calculation is completely wrong. From the original codes, it wants > to

[PATCH 05/22] hw/sd: sd: Drop sd_crc16()

2020-12-31 Thread Bin Meng
From: Bin Meng commit f6fb1f9b319f ("sdcard: Correct CRC16 offset in sd_function_switch()") changed the 16-bit CRC to be stored at offset 64. In fact, this CRC calculation is completely wrong. From the original codes, it wants to calculate the CRC16 of the first 64 bytes of sd->data[], however