Re: [PATCH 1/2] block: Fix Transaction leak in bdrv_root_attach_child()

2021-05-03 Thread Vladimir Sementsov-Ogievskiy
03.05.2021 15:14, Vladimir Sementsov-Ogievskiy wrote: 03.05.2021 14:53, Max Reitz wrote: On 03.05.21 13:51, Vladimir Sementsov-Ogievskiy wrote: 03.05.2021 14:49, Max Reitz wrote: On 03.05.21 13:05, Kevin Wolf wrote: The error path needs to call tran_finalize(), too. Fixes: CID 1452773

Re: [PATCH 1/2] block: Fix Transaction leak in bdrv_root_attach_child()

2021-05-03 Thread Vladimir Sementsov-Ogievskiy
03.05.2021 14:53, Max Reitz wrote: On 03.05.21 13:51, Vladimir Sementsov-Ogievskiy wrote: 03.05.2021 14:49, Max Reitz wrote: On 03.05.21 13:05, Kevin Wolf wrote: The error path needs to call tran_finalize(), too. Fixes: CID 1452773 Fixes: 548a74c0dbc858edd1a7ee3045b5f2fe710bd8b1

Re: [PATCH 1/2] block: Fix Transaction leak in bdrv_root_attach_child()

2021-05-03 Thread Vladimir Sementsov-Ogievskiy
03.05.2021 14:49, Max Reitz wrote: On 03.05.21 13:05, Kevin Wolf wrote: The error path needs to call tran_finalize(), too. Fixes: CID 1452773 Fixes: 548a74c0dbc858edd1a7ee3045b5f2fe710bd8b1 Signed-off-by: Kevin Wolf ---   block.c | 7 ---   1 file changed, 4 insertions(+), 3 deletions(-)

Re: [PATCH 1/2] block: Fix Transaction leak in bdrv_root_attach_child()

2021-05-03 Thread Max Reitz
On 03.05.21 13:51, Vladimir Sementsov-Ogievskiy wrote: 03.05.2021 14:49, Max Reitz wrote: On 03.05.21 13:05, Kevin Wolf wrote: The error path needs to call tran_finalize(), too. Fixes: CID 1452773 Fixes: 548a74c0dbc858edd1a7ee3045b5f2fe710bd8b1 Signed-off-by: Kevin Wolf ---   block.c | 7

Re: [PATCH 1/2] block: Fix Transaction leak in bdrv_root_attach_child()

2021-05-03 Thread Max Reitz
On 03.05.21 13:05, Kevin Wolf wrote: The error path needs to call tran_finalize(), too. Fixes: CID 1452773 Fixes: 548a74c0dbc858edd1a7ee3045b5f2fe710bd8b1 Signed-off-by: Kevin Wolf --- block.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index

Re: [PATCH 1/2] block: Fix Transaction leak in bdrv_root_attach_child()

2021-05-03 Thread Vladimir Sementsov-Ogievskiy
03.05.2021 14:05, Kevin Wolf wrote: The error path needs to call tran_finalize(), too. Fixes: CID 1452773 Fixes: 548a74c0dbc858edd1a7ee3045b5f2fe710bd8b1 Signed-off-by: Kevin Wolf --- block.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index

[PATCH 1/2] block: Fix Transaction leak in bdrv_root_attach_child()

2021-05-03 Thread Kevin Wolf
The error path needs to call tran_finalize(), too. Fixes: CID 1452773 Fixes: 548a74c0dbc858edd1a7ee3045b5f2fe710bd8b1 Signed-off-by: Kevin Wolf --- block.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 874c22c43e..5c0ced6238 100644 ---