Re: [PATCH 1/3] vhost-user-blk-test: fix Coverity open(2) false positives

2021-06-01 Thread Stefan Hajnoczi
On Sun, May 30, 2021 at 08:05:49PM +0100, Peter Maydell wrote: > On Wed, 26 May 2021 at 10:16, Stefan Hajnoczi wrote: > > > > Coverity checks that the file descriptor return value of open(2) is > > checked and used. Normally this is helpful in identifying real bugs but > > vhost-user-blk-test

Re: [PATCH 1/3] vhost-user-blk-test: fix Coverity open(2) false positives

2021-05-30 Thread Peter Maydell
On Wed, 26 May 2021 at 10:16, Stefan Hajnoczi wrote: > > Coverity checks that the file descriptor return value of open(2) is > checked and used. Normally this is helpful in identifying real bugs but > vhost-user-blk-test opens /dev/null as stdin and stdout after fork. > > In this case we don't

[PATCH 1/3] vhost-user-blk-test: fix Coverity open(2) false positives

2021-05-26 Thread Stefan Hajnoczi
Coverity checks that the file descriptor return value of open(2) is checked and used. Normally this is helpful in identifying real bugs but vhost-user-blk-test opens /dev/null as stdin and stdout after fork. In this case we don't need to look at the return value because these open(2) calls cannot