Re: [PATCH 1/4] qcow2: Improve refcount structure rebuilding

2021-03-26 Thread Vladimir Sementsov-Ogievskiy
26.03.2021 16:47, Max Reitz wrote: On 26.03.21 12:48, Vladimir Sementsov-Ogievskiy wrote: 10.03.2021 18:59, Max Reitz wrote: When rebuilding the refcount structures (when qemu-img check -r found errors with refcount = 0, but reference count > 0), the new refcount table defaults to being put at

Re: [PATCH 1/4] qcow2: Improve refcount structure rebuilding

2021-03-26 Thread Max Reitz
On 26.03.21 12:48, Vladimir Sementsov-Ogievskiy wrote: 10.03.2021 18:59, Max Reitz wrote: When rebuilding the refcount structures (when qemu-img check -r found errors with refcount = 0, but reference count > 0), the new refcount table defaults to being put at the image file end[1].  There is no

Re: [PATCH 1/4] qcow2: Improve refcount structure rebuilding

2021-03-26 Thread Vladimir Sementsov-Ogievskiy
10.03.2021 18:59, Max Reitz wrote: When rebuilding the refcount structures (when qemu-img check -r found errors with refcount = 0, but reference count > 0), the new refcount table defaults to being put at the image file end[1]. There is no good reason for that except that it means we will not

[PATCH 1/4] qcow2: Improve refcount structure rebuilding

2021-03-10 Thread Max Reitz
When rebuilding the refcount structures (when qemu-img check -r found errors with refcount = 0, but reference count > 0), the new refcount table defaults to being put at the image file end[1]. There is no good reason for that except that it means we will not have to rewrite any refblocks we