Re: [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check().

2022-03-22 Thread John Snow
On Tue, Mar 22, 2022 at 1:00 PM Hanna Reitz wrote: > > On 18.03.22 21:36, John Snow wrote: > > Like qemu-img, qemu-io returning 0 should be the norm and not the > > exception. Remove all calls to qemu_io_silent that just assert the > > return code is zero (That's every last call, as it turns out),

Re: [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check().

2022-03-22 Thread Hanna Reitz
On 18.03.22 21:36, John Snow wrote: Like qemu-img, qemu-io returning 0 should be the norm and not the exception. Remove all calls to qemu_io_silent that just assert the return code is zero (That's every last call, as it turns out), and replace them with a normal qemu_io() call. Signed-off-by: Jo

Re: [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check().

2022-03-21 Thread John Snow
On Mon, Mar 21, 2022 at 2:16 PM Eric Blake wrote: > > On Fri, Mar 18, 2022 at 04:36:54PM -0400, John Snow wrote: > > Like qemu-img, qemu-io returning 0 should be the norm and not the > > exception. Remove all calls to qemu_io_silent that just assert the > > return code is zero (That's every last c

Re: [PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check().

2022-03-21 Thread Eric Blake
On Fri, Mar 18, 2022 at 04:36:54PM -0400, John Snow wrote: > Like qemu-img, qemu-io returning 0 should be the norm and not the > exception. Remove all calls to qemu_io_silent that just assert the > return code is zero (That's every last call, as it turns out), and > replace them with a normal qemu_

[PATCH 14/15] iotests: remove qemu_io_silent() and qemu_io_silent_check().

2022-03-18 Thread John Snow
Like qemu-img, qemu-io returning 0 should be the norm and not the exception. Remove all calls to qemu_io_silent that just assert the return code is zero (That's every last call, as it turns out), and replace them with a normal qemu_io() call. Signed-off-by: John Snow --- tests/qemu-iotests/216