Re: [PATCH 18/21] parallels: naive implementation of parallels_co_pdiscard

2023-09-18 Thread Denis V. Lunev
On 9/18/23 15:57, Alexander Ivanov wrote: On 9/15/23 20:41, Denis V. Lunev wrote: * Discarding with backing stores is not supported by the format. * There is no buffering/queueing of the discard operation. * Only operations aligned to the cluster are supported. Signed-off-by: Denis V. Lunev

Re: [PATCH 18/21] parallels: naive implementation of parallels_co_pdiscard

2023-09-18 Thread Alexander Ivanov
On 9/15/23 20:41, Denis V. Lunev wrote: * Discarding with backing stores is not supported by the format. * There is no buffering/queueing of the discard operation. * Only operations aligned to the cluster are supported. Signed-off-by: Denis V. Lunev --- block/parallels.c | 47

Re: [PATCH 18/21] parallels: naive implementation of parallels_co_pdiscard

2023-09-17 Thread Mike Maslenkin
I got a warning after this patch: ../block/parallels.c:541:25: warning: 'guarded_by' attribute only applies to non-static data members and global variables [-Wignored-attributes] static int coroutine_fn GRAPH_RDLOCK_PTR ^

[PATCH 18/21] parallels: naive implementation of parallels_co_pdiscard

2023-09-15 Thread Denis V. Lunev
* Discarding with backing stores is not supported by the format. * There is no buffering/queueing of the discard operation. * Only operations aligned to the cluster are supported. Signed-off-by: Denis V. Lunev --- block/parallels.c | 47 +++ 1 file