Re: [PATCH 2/2] nbd/proto: add NBD_CMD_WRITE_ZEROES64

2020-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2020 16:12, Eric Blake wrote: On 2/5/20 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: Add new structured request type to represent 64bit version of NBD_CMD_WRITE_ZEROES. Initial reaction: why do we need a new NBD_CMD?  Why can't we reuse the existing NBD_CMD_WRITE_ZEROES, and merely

Re: [PATCH 2/2] nbd/proto: add NBD_CMD_WRITE_ZEROES64

2020-02-06 Thread Eric Blake
On 2/5/20 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: Add new structured request type to represent 64bit version of NBD_CMD_WRITE_ZEROES. Initial reaction: why do we need a new NBD_CMD? Why can't we reuse the existing NBD_CMD_WRITE_ZEROES, and merely document that if structured messages

[PATCH 2/2] nbd/proto: add NBD_CMD_WRITE_ZEROES64

2020-02-05 Thread Vladimir Sementsov-Ogievskiy
Add new structured request type to represent 64bit version of NBD_CMD_WRITE_ZEROES. Signed-off-by: Vladimir Sementsov-Ogievskiy --- doc/proto.md | 26 ++ 1 file changed, 26 insertions(+) diff --git a/doc/proto.md b/doc/proto.md index cb0ac56..378a800 100644 ---