Re: [PATCH 3/4] block/nbd: fix reconnect-delay

2020-09-23 Thread Eric Blake
On 9/3/20 2:03 PM, Vladimir Sementsov-Ogievskiy wrote: reconnect-delay has a design flaw: we handle it in the same loop where we do connection attempt. So, reconnect-delay may be exceeded by unpredictable time of connection attempt. Let's instead use separate timer. How to reproduce the bug:

[PATCH 3/4] block/nbd: fix reconnect-delay

2020-09-03 Thread Vladimir Sementsov-Ogievskiy
reconnect-delay has a design flaw: we handle it in the same loop where we do connection attempt. So, reconnect-delay may be exceeded by unpredictable time of connection attempt. Let's instead use separate timer. How to reproduce the bug: 1. Create an image on node1: qemu-img create -f qcow2 x