Re: [PATCH 6/9] qemu-file: remove shutdown member

2023-05-04 Thread Daniel P . Berrangé
On Thu, May 04, 2023 at 01:38:38PM +0200, Juan Quintela wrote: > The first thing that we do after setting the shutdown value is set the > error as -EIO if there is not a previous error. > > So this value is reduntant. Just remove it and use s/reduntant/redundant/ > qemu_file_get_error() in

Re: [PATCH 6/9] qemu-file: remove shutdown member

2023-05-04 Thread Peter Xu
On Thu, May 04, 2023 at 01:38:38PM +0200, Juan Quintela wrote: > The first thing that we do after setting the shutdown value is set the > error as -EIO if there is not a previous error. > > So this value is reduntant. Just remove it and use > qemu_file_get_error() in the places that it was

[PATCH 6/9] qemu-file: remove shutdown member

2023-05-04 Thread Juan Quintela
The first thing that we do after setting the shutdown value is set the error as -EIO if there is not a previous error. So this value is reduntant. Just remove it and use qemu_file_get_error() in the places that it was tested. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 10