Re: [PATCH for-5.0] aio-posix: signal-proof fdmon-io_uring

2020-04-09 Thread Stefano Garzarella
On Thu, Apr 09, 2020 at 03:57:09PM +0100, Stefan Hajnoczi wrote: > On Wed, Apr 08, 2020 at 12:06:03PM +0200, Stefano Garzarella wrote: > > On Wed, Apr 08, 2020 at 10:11:39AM +0100, Stefan Hajnoczi wrote: > > > The io_uring_enter(2) syscall returns with errno=EINTR when interrupted > > > by a

Re: [PATCH for-5.0] aio-posix: signal-proof fdmon-io_uring

2020-04-09 Thread Stefan Hajnoczi
On Wed, Apr 08, 2020 at 12:06:03PM +0200, Stefano Garzarella wrote: > On Wed, Apr 08, 2020 at 10:11:39AM +0100, Stefan Hajnoczi wrote: > > The io_uring_enter(2) syscall returns with errno=EINTR when interrupted > > by a signal. Retry the syscall in this case. > > > > It's essential to do this in

Re: [PATCH for-5.0] aio-posix: signal-proof fdmon-io_uring

2020-04-09 Thread Stefan Hajnoczi
On Wed, Apr 08, 2020 at 10:11:39AM +0100, Stefan Hajnoczi wrote: > The io_uring_enter(2) syscall returns with errno=EINTR when interrupted > by a signal. Retry the syscall in this case. > > It's essential to do this in the io_uring_submit_and_wait() case. My > interpretation of the Linux v5.5

Re: [PATCH for-5.0] aio-posix: signal-proof fdmon-io_uring

2020-04-08 Thread Philippe Mathieu-Daudé
On 4/8/20 11:11 AM, Stefan Hajnoczi wrote: The io_uring_enter(2) syscall returns with errno=EINTR when interrupted by a signal. Retry the syscall in this case. It's essential to do this in the io_uring_submit_and_wait() case. My interpretation of the Linux v5.5 io_uring_enter(2) code is that

Re: [PATCH for-5.0] aio-posix: signal-proof fdmon-io_uring

2020-04-08 Thread Stefano Garzarella
On Wed, Apr 08, 2020 at 10:11:39AM +0100, Stefan Hajnoczi wrote: > The io_uring_enter(2) syscall returns with errno=EINTR when interrupted > by a signal. Retry the syscall in this case. > > It's essential to do this in the io_uring_submit_and_wait() case. My > interpretation of the Linux v5.5

[PATCH for-5.0] aio-posix: signal-proof fdmon-io_uring

2020-04-08 Thread Stefan Hajnoczi
The io_uring_enter(2) syscall returns with errno=EINTR when interrupted by a signal. Retry the syscall in this case. It's essential to do this in the io_uring_submit_and_wait() case. My interpretation of the Linux v5.5 io_uring_enter(2) code is that it shouldn't affect the io_uring_submit()