Re: [PATCH for-5.2 v2 3/9] pc-bios/s390-ccw: Introduce ENODEV define and remove guards of others

2020-08-27 Thread Thomas Huth
On 06/08/2020 15.27, Janosch Frank wrote: > On 8/6/20 12:53 PM, Thomas Huth wrote: >> Remove the "#ifndef E..." guards from the defines here - the header >> guard S390_CCW_H at the top of the file should avoid double definition, >> and if the error code is defined in a different file already,

Re: [PATCH for-5.2 v2 3/9] pc-bios/s390-ccw: Introduce ENODEV define and remove guards of others

2020-08-06 Thread Janosch Frank
On 8/6/20 12:53 PM, Thomas Huth wrote: > Remove the "#ifndef E..." guards from the defines here - the header > guard S390_CCW_H at the top of the file should avoid double definition, > and if the error code is defined in a different file already, we're in > trouble anyway, then it's better to see

Re: [PATCH for-5.2 v2 3/9] pc-bios/s390-ccw: Introduce ENODEV define and remove guards of others

2020-08-06 Thread Cornelia Huck
On Thu, 6 Aug 2020 12:53:43 +0200 Thomas Huth wrote: > Remove the "#ifndef E..." guards from the defines here - the header > guard S390_CCW_H at the top of the file should avoid double definition, > and if the error code is defined in a different file already, we're in > trouble anyway, then

[PATCH for-5.2 v2 3/9] pc-bios/s390-ccw: Introduce ENODEV define and remove guards of others

2020-08-06 Thread Thomas Huth
Remove the "#ifndef E..." guards from the defines here - the header guard S390_CCW_H at the top of the file should avoid double definition, and if the error code is defined in a different file already, we're in trouble anyway, then it's better to see the error at compile time instead of hunting