Re: [PATCH v2 03/36] block: bdrv_append(): don't consume reference

Am 18.01.2021 um 18:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > 18.01.2021 17:18, Kevin Wolf wrote: > > Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > We have too much comments for this feature. It seems better just don't > > > do it. Most of real users (tests

Re: [PATCH v2 03/36] block: bdrv_append(): don't consume reference

18.01.2021 17:18, Kevin Wolf wrote: Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben: We have too much comments for this feature. It seems better just don't do it. Most of real users (tests don't count) have to create additional reference. Drop also comment in

Re: [PATCH v2 03/36] block: bdrv_append(): don't consume reference

Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > We have too much comments for this feature. It seems better just don't > do it. Most of real users (tests don't count) have to create additional > reference. > > Drop also comment in external_snapshot_prepare: > - bdrv_append

[PATCH v2 03/36] block: bdrv_append(): don't consume reference

We have too much comments for this feature. It seems better just don't do it. Most of real users (tests don't count) have to create additional reference. Drop also comment in external_snapshot_prepare: - bdrv_append doesn't "remove" old bs in common sense, it sounds strange - the fact that