Re: [PATCH v2 08/20] nvme: add support for the get log page command

2019-11-19 Thread Klaus Birkelund
On Tue, Nov 12, 2019 at 03:04:52PM +, Beata Michalska wrote: > Hi Klaus, > > > On Tue, 15 Oct 2019 at 11:45, Klaus Jensen wrote: > > +if (!nsid || (nsid != 0x && nsid > n->num_namespaces)) { > > +trace_nvme_err_invalid_ns(nsid, n->num_namespaces); > > +return NVME

Re: [PATCH v2 08/20] nvme: add support for the get log page command

2019-11-12 Thread Beata Michalska
Hi Klaus, On Tue, 15 Oct 2019 at 11:45, Klaus Jensen wrote: > > Add support for the Get Log Page command and basic implementations > of the mandatory Error Information, SMART/Health Information and > Firmware Slot Information log pages. > > In violation of the specification, the SMART/Health Inf

[PATCH v2 08/20] nvme: add support for the get log page command

2019-10-15 Thread Klaus Jensen
Add support for the Get Log Page command and basic implementations of the mandatory Error Information, SMART/Health Information and Firmware Slot Information log pages. In violation of the specification, the SMART/Health Information log page does not persist information over the lifetime of the co