Re: [PATCH v2 1/3] iotests: Fix 173

2019-10-18 Thread Eric Blake
On 10/17/19 7:17 AM, Max Reitz wrote: Why haven't we noticed the failure? Because the test rarely gets run: './check -qcow2 173' is insufficient (that defaults to using file protocol) './check -nfs 173' is insufficient (that defaults to using raw format) so the test is only run with: ./check

Re: [PATCH v2 1/3] iotests: Fix 173

2019-10-17 Thread Max Reitz
On 17.10.19 13:46, Max Reitz wrote: > On 15.10.19 21:35, Eric Blake wrote: >> This test has been broken since 3.0. It used TEST_IMG to influence >> the name of a file created during _make_test_img, but commit 655ae6bb >> changed things so that the wrong file name is being created, which >> then

Re: [PATCH v2 1/3] iotests: Fix 173

2019-10-17 Thread Max Reitz
On 15.10.19 21:35, Eric Blake wrote: > This test has been broken since 3.0. It used TEST_IMG to influence > the name of a file created during _make_test_img, but commit 655ae6bb > changed things so that the wrong file name is being created, which > then caused _launch_qemu to fail. In the

Re: [PATCH v2 1/3] iotests: Fix 173

2019-10-17 Thread Max Reitz
On 15.10.19 21:35, Eric Blake wrote: > This test has been broken since 3.0. It used TEST_IMG to influence > the name of a file created during _make_test_img, but commit 655ae6bb > changed things so that the wrong file name is being created, which > then caused _launch_qemu to fail. In the

[PATCH v2 1/3] iotests: Fix 173

2019-10-15 Thread Eric Blake
This test has been broken since 3.0. It used TEST_IMG to influence the name of a file created during _make_test_img, but commit 655ae6bb changed things so that the wrong file name is being created, which then caused _launch_qemu to fail. In the meantime, the set of events issued for the actions