Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-21 Thread Stefan Hajnoczi
On Wed, Feb 12, 2020 at 11:18:32AM +, Stefan Hajnoczi wrote: > On Tue, Feb 11, 2020 at 11:31:17AM -0500, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 04:20:41PM +, Stefan Hajnoczi wrote: > > > On Mon, Feb 03, 2020 at 12:39:49PM +0100, Sergio Lopez wrote: > > > > On Mon, Feb 03,

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-12 Thread Stefan Hajnoczi
On Tue, Feb 11, 2020 at 11:31:17AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 11, 2020 at 04:20:41PM +, Stefan Hajnoczi wrote: > > On Mon, Feb 03, 2020 at 12:39:49PM +0100, Sergio Lopez wrote: > > > On Mon, Feb 03, 2020 at 10:57:44AM +, Daniel P. Berrangé wrote: > > > > On Mon, Feb 03,

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 04:20:41PM +, Stefan Hajnoczi wrote: > On Mon, Feb 03, 2020 at 12:39:49PM +0100, Sergio Lopez wrote: > > On Mon, Feb 03, 2020 at 10:57:44AM +, Daniel P. Berrangé wrote: > > > On Mon, Feb 03, 2020 at 11:25:29AM +0100, Sergio Lopez wrote: > > > > On Thu, Jan 30, 2020

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-11 Thread Stefan Hajnoczi
On Mon, Feb 03, 2020 at 12:39:49PM +0100, Sergio Lopez wrote: > On Mon, Feb 03, 2020 at 10:57:44AM +, Daniel P. Berrangé wrote: > > On Mon, Feb 03, 2020 at 11:25:29AM +0100, Sergio Lopez wrote: > > > On Thu, Jan 30, 2020 at 10:52:35AM +, Stefan Hajnoczi wrote: > > > > On Thu, Jan 30, 2020

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-03 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 12:39:49PM +0100, Sergio Lopez wrote: > On Mon, Feb 03, 2020 at 10:57:44AM +, Daniel P. Berrangé wrote: > > On Mon, Feb 03, 2020 at 11:25:29AM +0100, Sergio Lopez wrote: > > > On Thu, Jan 30, 2020 at 10:52:35AM +, Stefan Hajnoczi wrote: > > > > On Thu, Jan 30, 2020

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-03 Thread Sergio Lopez
On Mon, Feb 03, 2020 at 10:57:44AM +, Daniel P. Berrangé wrote: > On Mon, Feb 03, 2020 at 11:25:29AM +0100, Sergio Lopez wrote: > > On Thu, Jan 30, 2020 at 10:52:35AM +, Stefan Hajnoczi wrote: > > > On Thu, Jan 30, 2020 at 01:29:16AM +0100, Paolo Bonzini wrote: > > > > On 29/01/20 16:44,

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-03 Thread Daniel P . Berrangé
On Mon, Feb 03, 2020 at 11:25:29AM +0100, Sergio Lopez wrote: > On Thu, Jan 30, 2020 at 10:52:35AM +, Stefan Hajnoczi wrote: > > On Thu, Jan 30, 2020 at 01:29:16AM +0100, Paolo Bonzini wrote: > > > On 29/01/20 16:44, Stefan Hajnoczi wrote: > > > > On Mon, Jan 27, 2020 at 02:10:31PM +0100,

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-03 Thread Cornelia Huck
On Mon, 3 Feb 2020 11:25:29 +0100 Sergio Lopez wrote: > On Thu, Jan 30, 2020 at 10:52:35AM +, Stefan Hajnoczi wrote: > > On Thu, Jan 30, 2020 at 01:29:16AM +0100, Paolo Bonzini wrote: > > > On 29/01/20 16:44, Stefan Hajnoczi wrote: > > > > On Mon, Jan 27, 2020 at 02:10:31PM +0100,

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-03 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 11:25:29AM +0100, Sergio Lopez wrote: > On Thu, Jan 30, 2020 at 10:52:35AM +, Stefan Hajnoczi wrote: > > On Thu, Jan 30, 2020 at 01:29:16AM +0100, Paolo Bonzini wrote: > > > On 29/01/20 16:44, Stefan Hajnoczi wrote: > > > > On Mon, Jan 27, 2020 at 02:10:31PM +0100,

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-03 Thread Sergio Lopez
On Thu, Jan 30, 2020 at 10:52:35AM +, Stefan Hajnoczi wrote: > On Thu, Jan 30, 2020 at 01:29:16AM +0100, Paolo Bonzini wrote: > > On 29/01/20 16:44, Stefan Hajnoczi wrote: > > > On Mon, Jan 27, 2020 at 02:10:31PM +0100, Cornelia Huck wrote: > > >> On Fri, 24 Jan 2020 10:01:57 + > > >>

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-01-30 Thread Cornelia Huck
On Thu, 30 Jan 2020 10:52:35 + Stefan Hajnoczi wrote: > On Thu, Jan 30, 2020 at 01:29:16AM +0100, Paolo Bonzini wrote: > > On 29/01/20 16:44, Stefan Hajnoczi wrote: > > > On Mon, Jan 27, 2020 at 02:10:31PM +0100, Cornelia Huck wrote: > > >> On Fri, 24 Jan 2020 10:01:57 + > > >>

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-01-30 Thread Stefan Hajnoczi
On Thu, Jan 30, 2020 at 01:29:16AM +0100, Paolo Bonzini wrote: > On 29/01/20 16:44, Stefan Hajnoczi wrote: > > On Mon, Jan 27, 2020 at 02:10:31PM +0100, Cornelia Huck wrote: > >> On Fri, 24 Jan 2020 10:01:57 + > >> Stefan Hajnoczi wrote: > >>> @@ -47,10 +48,15 @@ static void

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-01-29 Thread Paolo Bonzini
On 29/01/20 16:44, Stefan Hajnoczi wrote: > On Mon, Jan 27, 2020 at 02:10:31PM +0100, Cornelia Huck wrote: >> On Fri, 24 Jan 2020 10:01:57 + >> Stefan Hajnoczi wrote: >>> @@ -47,10 +48,15 @@ static void vhost_scsi_pci_realize(VirtIOPCIProxy >>> *vpci_dev, Error **errp) >>> { >>>

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-01-29 Thread Stefan Hajnoczi
On Mon, Jan 27, 2020 at 02:10:31PM +0100, Cornelia Huck wrote: > On Fri, 24 Jan 2020 10:01:57 + > Stefan Hajnoczi wrote: > > @@ -47,10 +48,15 @@ static void vhost_scsi_pci_realize(VirtIOPCIProxy > > *vpci_dev, Error **errp) > > { > > VHostSCSIPCI *dev = VHOST_SCSI_PCI(vpci_dev); > >

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-01-27 Thread Cornelia Huck
On Fri, 24 Jan 2020 10:01:57 + Stefan Hajnoczi wrote: > Automatically size the number of request virtqueues to match the number "If the pci transport is used, ..." ? > of vCPUs. This ensures that completion interrupts are handled on the > same vCPU that submitted the request. No IPI is

[PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-01-24 Thread Stefan Hajnoczi
Automatically size the number of request virtqueues to match the number of vCPUs. This ensures that completion interrupts are handled on the same vCPU that submitted the request. No IPI is necessary to complete an I/O request and performance is improved. Signed-off-by: Stefan Hajnoczi ---