Re: [PATCH v2 23/36] block: adapt bdrv_append() for inserting filters

04.02.2021 12:05, Kevin Wolf wrote: Am 04.02.2021 um 09:30 hat Vladimir Sementsov-Ogievskiy geschrieben: 04.02.2021 00:33, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: int bdrv_append(BlockDriverState *bs_new, BlockDriverState *bs_top,

Re: [PATCH v2 23/36] block: adapt bdrv_append() for inserting filters

Am 04.02.2021 um 09:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > 04.02.2021 00:33, Kevin Wolf wrote: > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > int bdrv_append(BlockDriverState *bs_new, BlockDriverState *bs_top, > > > Error **errp) > >

Re: [PATCH v2 23/36] block: adapt bdrv_append() for inserting filters

04.02.2021 00:33, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: bdrv_append is not very good for inserting filters: it does extra permission update as part of bdrv_set_backing_hd(). During this update filter may conflict with other parents of top_bs.

Re: [PATCH v2 23/36] block: adapt bdrv_append() for inserting filters

Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > bdrv_append is not very good for inserting filters: it does extra > permission update as part of bdrv_set_backing_hd(). During this update > filter may conflict with other parents of top_bs. > > Instead, let's first do all

[PATCH v2 23/36] block: adapt bdrv_append() for inserting filters

bdrv_append is not very good for inserting filters: it does extra permission update as part of bdrv_set_backing_hd(). During this update filter may conflict with other parents of top_bs. Instead, let's first do all graph modifications and after it update permissions. Note: bdrv_append() is still