Re: [PATCH v2 25/36] block: introduce bdrv_drop_filter()

2021-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2021 14:31, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: Using bdrv_replace_node() for removing filter is not good enough: it keeps child reference of the filter, which may conflict with original top node during permission update. Instead let's

Re: [PATCH v2 25/36] block: introduce bdrv_drop_filter()

2021-02-04 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > Using bdrv_replace_node() for removing filter is not good enough: it > keeps child reference of the filter, which may conflict with original > top node during permission update. > > Instead let's create new interface, which

[PATCH v2 25/36] block: introduce bdrv_drop_filter()

2020-11-27 Thread Vladimir Sementsov-Ogievskiy
Using bdrv_replace_node() for removing filter is not good enough: it keeps child reference of the filter, which may conflict with original top node during permission update. Instead let's create new interface, which will do all graph modifications first and then update permissions. Let's modify