Re: [PATCH v2 3/3] nbd: disable signals and forking on Windows builds

2020-09-03 Thread Yonggang Luo
On Thu, Sep 3, 2020 at 7:29 AM Eric Blake wrote: > On 9/2/20 5:07 PM, 罗勇刚(Yonggang Luo) wrote: > > On Tue, Aug 25, 2020 at 6:40 PM Daniel P. Berrangé > > wrote: > > > >> Disabling these parts are sufficient to get the qemu-nbd program > >> compiling in a Windows build. > >> > >> Signed-off-by: D

Re: [PATCH v2 3/3] nbd: disable signals and forking on Windows builds

2020-09-02 Thread Yonggang Luo
On Tue, Aug 25, 2020 at 6:40 PM Daniel P. Berrangé wrote: > Disabling these parts are sufficient to get the qemu-nbd program > compiling in a Windows build. > > Signed-off-by: Daniel P. Berrangé > --- > meson.build | 7 ++- > qemu-nbd.c | 5 + > 2 files changed, 7 insertions(+), 5 dele

Re: [PATCH v2 3/3] nbd: disable signals and forking on Windows builds

2020-09-02 Thread Eric Blake
On 9/2/20 5:07 PM, 罗勇刚(Yonggang Luo) wrote: On Tue, Aug 25, 2020 at 6:40 PM Daniel P. Berrangé wrote: Disabling these parts are sufficient to get the qemu-nbd program compiling in a Windows build. Signed-off-by: Daniel P. Berrangé --- meson.build | 7 ++- qemu-nbd.c | 5 + 2 fil

Re: [PATCH v2 3/3] nbd: disable signals and forking on Windows builds

2020-09-02 Thread Eric Blake
On 8/25/20 5:38 AM, Daniel P. Berrangé wrote: Disabling these parts are sufficient to get the qemu-nbd program compiling in a Windows build. Signed-off-by: Daniel P. Berrangé --- meson.build | 7 ++- qemu-nbd.c | 5 + 2 files changed, 7 insertions(+), 5 deletions(-) Reviewed-by:

[PATCH v2 3/3] nbd: disable signals and forking on Windows builds

2020-08-25 Thread Daniel P . Berrangé
Disabling these parts are sufficient to get the qemu-nbd program compiling in a Windows build. Signed-off-by: Daniel P. Berrangé --- meson.build | 7 ++- qemu-nbd.c | 5 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/meson.build b/meson.build index df5bf728b5..10718716