Re: [PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 20:13, Thomas Huth wrote: On 21/02/2024 19.43, Philippe Mathieu-Daudé wrote: On 20/2/24 09:55, Thomas Huth wrote: Unentangle internal.h by moving public IDE device related Disentangle ... from? Untangle? TIL Unentangle. You're right, "disentangle" seems to be the more appropriate

Re: [PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h

2024-02-21 Thread Thomas Huth
On 21/02/2024 19.43, Philippe Mathieu-Daudé wrote: On 20/2/24 09:55, Thomas Huth wrote: Unentangle internal.h by moving public IDE device related Disentangle ... from? Untangle? TIL Unentangle. You're right, "disentangle" seems to be the more appropriate word. I'll fix it up. Anyway I'm no

Re: [PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h

2024-02-21 Thread Philippe Mathieu-Daudé
On 20/2/24 09:55, Thomas Huth wrote: Unentangle internal.h by moving public IDE device related Disentangle ... from? Untangle? TIL Unentangle. Anyway I'm not a native English speaker, so: Reviewed-by: Philippe Mathieu-Daudé definitions to ide-dev.h. Signed-off-by: Thomas Huth --- includ

[PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h

2024-02-20 Thread Thomas Huth
Unentangle internal.h by moving public IDE device related definitions to ide-dev.h. Signed-off-by: Thomas Huth --- include/hw/ide/ide-dev.h | 143 +- include/hw/ide/internal.h | 143 +- hw/ide/ide-dev.c | 1 + 3