Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Daniel P . Berrangé
On Fri, Dec 17, 2021 at 02:53:05PM +, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Thu, Dec 16, 2021 at 02:11:37PM +, Alex Bennée wrote: > >> > >> Philippe Mathieu-Daudé writes: > >> > >> > When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 > >> > (Fedora 34 pr

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Alex Bennée
Daniel P. Berrangé writes: > On Thu, Dec 16, 2021 at 02:11:37PM +, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >> > When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 >> > (Fedora 34 provides GLib 2.68.1) we get: >> > >> > hw/virtio/virtio-crypto.c:245:24: erro

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Daniel P . Berrangé
On Thu, Dec 16, 2021 at 02:11:37PM +, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 > > (Fedora 34 provides GLib 2.68.1) we get: > > > > hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use > > 'g

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Daniel P . Berrangé
On Fri, Dec 17, 2021 at 11:10:31AM +, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > On 12/16/21 15:11, Alex Bennée wrote: > >> Philippe Mathieu-Daudé writes: > >> > >>> When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 > >>> (Fedora 34 provides GLib 2.68.1) we get:

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Alex Bennée
Laurent Vivier writes: > Alex, > > I've added this patch to my trivial patches branch, do you want I drop > it? No - the patch itself is fine. I would like to fix up the consistency later if we can agree on what it should be. -- Alex Bennée

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Laurent Vivier
Alex, I've added this patch to my trivial patches branch, do you want I drop it? Thanks, Laurent On 17/12/2021 12:10, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 12/16/21 15:11, Alex Bennée wrote: Philippe Mathieu-Daudé writes: When experimenting raising GLIB_VERSION_MIN_REQUIR

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 12/16/21 15:11, Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: >> >>> When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 >>> (Fedora 34 provides GLib 2.68.1) we get: >>> >>> hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Laurent Vivier
Le 03/09/2021 à 19:44, Philippe Mathieu-Daudé a écrit : When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 (Fedora 34 provides GLib 2.68.1) we get: hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use 'g_memdup2' instead [-Werror,-Wdeprecated-declarations] ...

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-16 Thread Philippe Mathieu-Daudé
On 12/16/21 15:11, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: > >> When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 >> (Fedora 34 provides GLib 2.68.1) we get: >> >> hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use >> 'g_memdup2' instead [-Werror,-Wde

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 > (Fedora 34 provides GLib 2.68.1) we get: > > hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use > 'g_memdup2' instead [-Werror,-Wdeprecated-declarations] > ... > > g_memdup()

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-09-03 Thread Eric Blake
On Fri, Sep 03, 2021 at 07:44:44PM +0200, Philippe Mathieu-Daudé wrote: > When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 > (Fedora 34 provides GLib 2.68.1) we get: > > hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use > 'g_memdup2' instead [-Werror,-Wdeprecate

[PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-09-03 Thread Philippe Mathieu-Daudé
When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 (Fedora 34 provides GLib 2.68.1) we get: hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use 'g_memdup2' instead [-Werror,-Wdeprecated-declarations] ... g_memdup() has been updated by g_memdup2() to fix eventual