Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
14.09.2021 15:00, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 14:46, Hanna Reitz wrote: On 14.09.21 13:22, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
14.09.2021 14:46, Hanna Reitz wrote: On 14.09.21 13:22, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters:   - for compressed it must be zero  

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Hanna Reitz
On 14.09.21 13:22, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters:   - for compressed it must be zero   - for allocated check consistency of

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters:   - for compressed it must be zero   - for allocated check consistency of two parts of the bitmap   - for unallocated all

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters: - for compressed it must be zero - for allocated check consistency of two parts of the bitmap - for unallocated all subclusters should be unallocated (or

[PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-05-24 Thread Vladimir Sementsov-Ogievskiy
Check subcluster bitmap of the l2 entry for different types of clusters: - for compressed it must be zero - for allocated check consistency of two parts of the bitmap - for unallocated all subclusters should be unallocated (or zero-plain) For unallocated clusters we can safely fix the