Re: [PATCH v3 2/2] vhost: Add Error parameter to vhost_scsi_common_start()

2023-10-01 Thread Michael S. Tsirkin
On Tue, Sep 12, 2023 at 04:32:59PM +0800, Li Feng wrote: > Please mention in the commit message that error messages improve, and > silent errors are now reported. > > Ack. Still waiting for v4 with the updated commit log. -- MST

Re: [PATCH v3 2/2] vhost: Add Error parameter to vhost_scsi_common_start()

2023-09-12 Thread Li Feng
> On 1 Sep 2023, at 8:00 PM, Markus Armbruster wrote: > > Li Feng mailto:fen...@smartx.com>> writes: > >> Add a Error parameter to report the real error, like vhost-user-blk. >> >> Signed-off-by: Li Feng >> --- >> hw/scsi/vhost-scsi-common.c | 16 +--- >>

Re: [PATCH v3 2/2] vhost: Add Error parameter to vhost_scsi_common_start()

2023-09-01 Thread Markus Armbruster
Li Feng writes: > Add a Error parameter to report the real error, like vhost-user-blk. > > Signed-off-by: Li Feng > --- > hw/scsi/vhost-scsi-common.c | 16 +--- > hw/scsi/vhost-scsi.c | 5 +++-- > hw/scsi/vhost-user-scsi.c | 14 --

Re: [PATCH v3 2/2] vhost: Add Error parameter to vhost_scsi_common_start()

2023-08-30 Thread Raphael Norwitz
> On Aug 30, 2023, at 12:57 AM, Li Feng wrote: > > Add a Error parameter to report the real error, like vhost-user-blk. > Reviewed-by: Raphael Norwitz > Signed-off-by: Li Feng > --- > hw/scsi/vhost-scsi-common.c | 16 +--- > hw/scsi/vhost-scsi.c | 5

[PATCH v3 2/2] vhost: Add Error parameter to vhost_scsi_common_start()

2023-08-30 Thread Li Feng
Add a Error parameter to report the real error, like vhost-user-blk. Signed-off-by: Li Feng --- hw/scsi/vhost-scsi-common.c | 16 +--- hw/scsi/vhost-scsi.c | 5 +++-- hw/scsi/vhost-user-scsi.c | 14 --