Re: [PATCH v3 3/4] hw/block/nvme: add smart_critical_warning property

2021-01-14 Thread Keith Busch
On Thu, Jan 14, 2021 at 03:22:50PM +0800, zhenwei pi wrote: > +static void nvme_get_smart_warning(Object *obj, Visitor *v, const char *name, > + void *opaque, Error **errp) > +{ > +NvmeCtrl *s = NVME(obj); With only one exception, all variables of type

Re: [PATCH v3 3/4] hw/block/nvme: add smart_critical_warning property

2021-01-14 Thread Philippe Mathieu-Daudé
On 1/14/21 8:22 AM, zhenwei pi wrote: > There is a very low probability that hitting physical NVMe disk > hardware critical warning case, it's hard to write & test a monitor > agent service. > > For debugging purposes, add a new 'smart_critical_warning' property > to emulate this situation. > >

Re: [PATCH v3 3/4] hw/block/nvme: add smart_critical_warning property

2021-01-14 Thread Klaus Jensen
On Jan 14 15:22, zhenwei pi wrote: > There is a very low probability that hitting physical NVMe disk > hardware critical warning case, it's hard to write & test a monitor > agent service. > > For debugging purposes, add a new 'smart_critical_warning' property > to emulate this situation. > > The

[PATCH v3 3/4] hw/block/nvme: add smart_critical_warning property

2021-01-13 Thread zhenwei pi
There is a very low probability that hitting physical NVMe disk hardware critical warning case, it's hard to write & test a monitor agent service. For debugging purposes, add a new 'smart_critical_warning' property to emulate this situation. The orignal version of this change is implemented by