Re: [PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning

2021-01-14 Thread Keith Busch
On Thu, Jan 14, 2021 at 03:22:51PM +0800, zhenwei pi wrote: > @@ -2860,6 +2887,12 @@ static void nvme_set_smart_warning(Object *obj, > Visitor *v, const char *name, > } > > s->smart_critical_warning = value; > + > +/* test each bit of uint8_t for smart.critical_warning */ > +

Re: [PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning

2021-01-14 Thread Philippe Mathieu-Daudé
On 1/14/21 8:22 AM, zhenwei pi wrote: > During smart critical warning injection by setting property from QMP > command, also try to trigger asynchronous event. > > Signed-off-by: zhenwei pi > --- > hw/block/nvme.c | 47 --- > 1 file changed, 40

Re: [PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning

2021-01-14 Thread Klaus Jensen
On Jan 14 15:22, zhenwei pi wrote: > During smart critical warning injection by setting property from QMP > command, also try to trigger asynchronous event. > > Signed-off-by: zhenwei pi > --- > hw/block/nvme.c | 47 --- > 1 file changed, 40

[PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning

2021-01-13 Thread zhenwei pi
During smart critical warning injection by setting property from QMP command, also try to trigger asynchronous event. Signed-off-by: zhenwei pi --- hw/block/nvme.c | 47 --- 1 file changed, 40 insertions(+), 7 deletions(-) diff --git