Re: [PATCH v3 6/9] qapi/block-core: use JobType for BlockJobInfo's type

2023-10-18 Thread Markus Armbruster
Fiona Ebner writes: > In preparation to turn BlockJobInfo into a union with @type as the > discriminator. That requires it to be an enum. > > No functional change is intended. > > Signed-off-by: Fiona Ebner > Reviewed-by: Vladimir Sementsov-Ogievskiy Replacing str by enum makes sense whether

[PATCH v3 6/9] qapi/block-core: use JobType for BlockJobInfo's type

2023-10-13 Thread Fiona Ebner
In preparation to turn BlockJobInfo into a union with @type as the discriminator. That requires it to be an enum. No functional change is intended. Signed-off-by: Fiona Ebner Reviewed-by: Vladimir Sementsov-Ogievskiy --- No changes in v3. block/monitor/block-hmp-cmds.c | 4 ++-- blockjob.c