Re: [PATCH v4] block-jobs: flush target at the end of .run()

2023-10-03 Thread Vladimir Sementsov-Ogievskiy
On 03.08.23 05:43, Evanzhang wrote: [...] diff --git a/block/mirror.c b/block/mirror.c index d3cacd1708..cd19b49f7f 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1143,6 +1143,10 @@ immediate_exit: g_free(s->in_flight_bitmap); bdrv_dirty_iter_free(s->dbi); +if (ret >= 0) {

Re: [PATCH v4] block-jobs: flush target at the end of .run()

2023-08-02 Thread Evanzhang
[...] >diff --git a/block/mirror.c b/block/mirror.c >index d3cacd1708..cd19b49f7f 100644 >--- a/block/mirror.c >+++ b/block/mirror.c >@@ -1143,6 +1143,10 @@ immediate_exit: > g_free(s->in_flight_bitmap); > bdrv_dirty_iter_free(s->dbi); > >+if (ret >= 0) { >+ret =

Re: [PATCH v4] block-jobs: flush target at the end of .run()

2023-07-27 Thread Vladimir Sementsov-Ogievskiy
On 27.07.23 18:27, Hanna Czenczek wrote: On 25.07.23 19:40, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Actually block job is not completed without this final flush. It's rather unexpected to have broken target when job was successfully completed long ago and now we

Re: [PATCH v4] block-jobs: flush target at the end of .run()

2023-07-27 Thread Hanna Czenczek
On 25.07.23 19:40, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Actually block job is not completed without this final flush. It's rather unexpected to have broken target when job was successfully completed long ago and now we fail to flush or process just

Re: [PATCH v4] block-jobs: flush target at the end of .run()

2023-07-26 Thread Denis V. Lunev
On 7/25/23 19:40, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Actually block job is not completed without this final flush. It's rather unexpected to have broken target when job was successfully completed long ago and now we fail to flush or process just

[PATCH v4] block-jobs: flush target at the end of .run()

2023-07-25 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Actually block job is not completed without this final flush. It's rather unexpected to have broken target when job was successfully completed long ago and now we fail to flush or process just crashed/killed. Signed-off-by: Vladimir Sementsov-Ogievskiy ---