Re: [PATCH v4 00/36] block: update graph permissions update

2021-05-05 Thread Vladimir Sementsov-Ogievskiy
28.04.2021 22:50, Vladimir Sementsov-Ogievskiy wrote: 28.04.2021 20:03, Kevin Wolf wrote: Am 28.04.2021 um 17:17 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! And here is v4. Thanks, applied to the block branch. Thanks! And thanks a lot for reviewing! Though the error message sh

Re: [PATCH v4 00/36] block: update graph permissions update

2021-04-28 Thread Vladimir Sementsov-Ogievskiy
28.04.2021 20:03, Kevin Wolf wrote: Am 28.04.2021 um 17:17 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! And here is v4. Thanks, applied to the block branch. Thanks! And thanks a lot for reviewing! Though the error message shown by the test in patch 18 does need some improvement

Re: [PATCH v4 00/36] block: update graph permissions update

2021-04-28 Thread Kevin Wolf
Am 28.04.2021 um 17:17 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > And here is v4. Thanks, applied to the block branch. Though the error message shown by the test in patch 18 does need some improvement on top. We should probably name both conflicting users and who blocks whom in

Re: [PATCH v4 00/36] block: update graph permissions update

2021-04-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210428151804.439460-1-vsement...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210428151804.439460-1-vsement...@virtuozzo.com Subject: [PATCH v4 00/36] block

[PATCH v4 00/36] block: update graph permissions update

2021-04-28 Thread Vladimir Sementsov-Ogievskiy
Hi all! And here is v4. v4: git: https://src.openvz.org/scm/~vsementsov/qemu.git tag: up-block-topologic-perm-v4 01: drop misleading comment 04: add missed bdrv_unref to new bdrv_append() caller 08: s/Than/Then/ in comment 18: add missed ".clean = g_free" to bdrv_attach_child_common_drv fix