Re: [PATCH v4 13/30] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-04-14 Thread Vladimir Sementsov-Ogievskiy
17.03.2020 21:16, Alberto Garcia wrote: This patch adds QCow2SubclusterType, which is the subcluster-level version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the the same meaning as their QCOW2_CLUSTER_* equivalents (when they exist). See below for details and caveats. In images wit

Re: [PATCH v4 13/30] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-04-09 Thread Max Reitz
On 08.04.20 19:46, Alberto Garcia wrote: > On Wed 08 Apr 2020 01:23:42 PM CEST, Max Reitz wrote: >>> +switch (type) { >>> +case QCOW2_CLUSTER_COMPRESSED: >>> +return QCOW2_SUBCLUSTER_COMPRESSED; >> >> Why did you drop the check that l2_bitmap == 0 here? > > We don't gen

Re: [PATCH v4 13/30] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-04-08 Thread Alberto Garcia
On Wed 08 Apr 2020 01:23:42 PM CEST, Max Reitz wrote: >> +switch (type) { >> +case QCOW2_CLUSTER_COMPRESSED: >> +return QCOW2_SUBCLUSTER_COMPRESSED; > > Why did you drop the check that l2_bitmap == 0 here? We don't generally check that reserved bits are 0. It would for

Re: [PATCH v4 13/30] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-04-08 Thread Max Reitz
On 17.03.20 19:16, Alberto Garcia wrote: > This patch adds QCow2SubclusterType, which is the subcluster-level > version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the > the same meaning as their QCOW2_CLUSTER_* equivalents (when they > exist). See below for details and caveats. > > In

[PATCH v4 13/30] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-03-17 Thread Alberto Garcia
This patch adds QCow2SubclusterType, which is the subcluster-level version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the the same meaning as their QCOW2_CLUSTER_* equivalents (when they exist). See below for details and caveats. In images without extended L2 entries clusters are trea