Re: [PATCH v4 2/6] util: refactor qemu_open_old to split off variadic args handling

2020-08-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Aug 25, 2020 at 04:56:40PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > This simple refactoring prepares for future patches. The variadic args >> > handling is split from the main bulk of the open logic. The duplicated >> > calls to

Re: [PATCH v4 2/6] util: refactor qemu_open_old to split off variadic args handling

2020-08-25 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 04:56:40PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > This simple refactoring prepares for future patches. The variadic args > > handling is split from the main bulk of the open logic. The duplicated > > calls to open() are removed in favour of

Re: [PATCH v4 2/6] util: refactor qemu_open_old to split off variadic args handling

2020-08-25 Thread Markus Armbruster
Daniel P. Berrangé writes: > This simple refactoring prepares for future patches. The variadic args > handling is split from the main bulk of the open logic. The duplicated > calls to open() are removed in favour of updating the "flags" variable > to have O_CLOEXEC. > > Signed-off-by: Daniel P.

[PATCH v4 2/6] util: refactor qemu_open_old to split off variadic args handling

2020-08-21 Thread Daniel P . Berrangé
This simple refactoring prepares for future patches. The variadic args handling is split from the main bulk of the open logic. The duplicated calls to open() are removed in favour of updating the "flags" variable to have O_CLOEXEC. Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 40