Re: [PATCH v5 4/5] block/nbd: drop connection_co

2021-07-14 Thread Vladimir Sementsov-Ogievskiy
[add Roman} 14.07.2021 19:59, Vladimir Sementsov-Ogievskiy wrote: OK, that's a big rewrite of the logic. Pre-patch we have an always running coroutine - connection_co. It does reply receiving and reconnecting. And it leads to a lot of difficult and unobvious code around drained sections and

[PATCH v5 4/5] block/nbd: drop connection_co

2021-07-14 Thread Vladimir Sementsov-Ogievskiy
OK, that's a big rewrite of the logic. Pre-patch we have an always running coroutine - connection_co. It does reply receiving and reconnecting. And it leads to a lot of difficult and unobvious code around drained sections and context switch. We also abuse bs->in_flight counter which is increased