Re: [PATCH v6 02/11] error: auto propagated local_err

2020-01-17 Thread Eric Blake
On 1/10/20 1:41 PM, Vladimir Sementsov-Ogievskiy wrote: Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with errp OUT parameter. s/with/with an/ It has three goals: 1. Fix issue with error_fatal & error_prepend/error_append_hint: user maybe s/&/and/ so it do

Re: [PATCH v6 02/11] error: auto propagated local_err

2020-01-15 Thread Greg Kurz
On Fri, 10 Jan 2020 22:41:49 +0300 Vladimir Sementsov-Ogievskiy wrote: > Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal & error_prepend/error_append_hint: user > can't see this a

Re: [PATCH v6 02/11] error: auto propagated local_err

2020-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2020 11:50, Paul Durrant wrote: > On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy > wrote: > [snip] >> +/* >> + * ERRP_AUTO_PROPAGATE >> + * >> + * This macro is created to be the first line of a function which use >> + * Error **errp parameter to report error. It's needed only in

Re: [PATCH v6 02/11] error: auto propagated local_err

2020-01-13 Thread Paul Durrant
On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy wrote: [snip] > +/* > + * ERRP_AUTO_PROPAGATE > + * > + * This macro is created to be the first line of a function which use > + * Error **errp parameter to report error. It's needed only in cases where we > + * want to use error_prepend,

[PATCH v6 02/11] error: auto propagated local_err

2020-01-10 Thread Vladimir Sementsov-Ogievskiy
Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with errp OUT parameter. It has three goals: 1. Fix issue with error_fatal & error_prepend/error_append_hint: user can't see this additional information, because exit() happens in error_setg earlier than information is