Re: [PATCH v9 5/7] multifd: multifd_send_sync_main now returns negative on error

2022-04-26 Thread Leonardo Bras Soares Passos
On Tue, Apr 26, 2022 at 9:59 AM Peter Xu wrote: > > On Mon, Apr 25, 2022 at 06:50:54PM -0300, Leonardo Bras wrote: > > Even though multifd_send_sync_main() currently emits error_reports, it's > > callers don't really check it before continuing. > > > > Change multifd_send_sync_main() to return -1

Re: [PATCH v9 5/7] multifd: multifd_send_sync_main now returns negative on error

2022-04-26 Thread Peter Xu
On Mon, Apr 25, 2022 at 06:50:54PM -0300, Leonardo Bras wrote: > Even though multifd_send_sync_main() currently emits error_reports, it's > callers don't really check it before continuing. > > Change multifd_send_sync_main() to return -1 on error and 0 on success. > Also change all it's callers

Re: [PATCH v9 5/7] multifd: multifd_send_sync_main now returns negative on error

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 06:50:54PM -0300, Leonardo Bras wrote: > Even though multifd_send_sync_main() currently emits error_reports, it's > callers don't really check it before continuing. > > Change multifd_send_sync_main() to return -1 on error and 0 on success. > Also change all it's callers

[PATCH v9 5/7] multifd: multifd_send_sync_main now returns negative on error

2022-04-25 Thread Leonardo Bras
Even though multifd_send_sync_main() currently emits error_reports, it's callers don't really check it before continuing. Change multifd_send_sync_main() to return -1 on error and 0 on success. Also change all it's callers to make use of this change and possibly fail earlier. (This change is