Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-16 Thread Kevin Wolf
Am 16.03.2022 um 16:25 hat Philippe Mathieu-Daudé geschrieben: > On 16/3/22 15:46, Emanuele Giuseppe Esposito wrote: > > Am 16/03/2022 um 13:53 schrieb Philippe Mathieu-Daudé: > > > On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: > > > > Hi, > > > > > > > > On 4/3/22 17:46, Kevin Wolf wrote: > >

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 15:46, Emanuele Giuseppe Esposito wrote: Am 16/03/2022 um 13:53 schrieb Philippe Mathieu-Daudé: On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: Hi, On 4/3/22 17:46, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito All the global state (GS) API functions will check that

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-16 Thread Emanuele Giuseppe Esposito
Am 16/03/2022 um 13:53 schrieb Philippe Mathieu-Daudé: > On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 4/3/22 17:46, Kevin Wolf wrote: >>> From: Emanuele Giuseppe Esposito >>> >>> All the global state (GS) API functions will check that >>> qemu_in_main_thread() returns true.

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-16 Thread Emanuele Giuseppe Esposito
Hi Philippe, How did you trigger this? What is the call stack? >From a first look, all callers of blk_all_next also call GLOBAL_STATE_CODE, except qmp_* functions. That would be useful to understand if we need to change the function assertion and classification, or the caller is breaking some

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-16 Thread Philippe Mathieu-Daudé
Hi, On 4/3/22 17:46, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito All the global state (GS) API functions will check that qemu_in_main_thread() returns true. If not, it means that the safety of BQL cannot be guaranteed, and they need to be moved to I/O. I'm getting this crash: $

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: Hi, On 4/3/22 17:46, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito All the global state (GS) API functions will check that qemu_in_main_thread() returns true. If not, it means that the safety of BQL cannot be guaranteed, and they need to

[PULL 21/50] block/block-backend.c: assertions for block-backend

2022-03-04 Thread Kevin Wolf
From: Emanuele Giuseppe Esposito All the global state (GS) API functions will check that qemu_in_main_thread() returns true. If not, it means that the safety of BQL cannot be guaranteed, and they need to be moved to I/O. Signed-off-by: Emanuele Giuseppe Esposito Message-Id: