Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-14 Thread Alexander Popov
On 07.11.2019 01:05, Alexander Popov wrote: > On 06.11.2019 15:05, Michael S. Tsirkin wrote: >> Do you want to cook up a patch like this then? > > Yes, I will take this task and return with a patch. > > Thanks! I've just sent the v2 of the patch. Looking forward to your feedback. Best regards,

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Alexander Popov
On 06.11.2019 15:05, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2019 at 08:25:03PM -0400, John Snow wrote: >> >> >> On 7/5/19 10:07 AM, Alexander Popov wrote: >>> This assertion was introduced in the commit a718978ed58a in July 2015. >>> It implies that the size of successful DMA transfers

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Alexander Popov
On 06.11.2019 15:08, Michael S. Tsirkin wrote: > On Wed, Nov 06, 2019 at 01:17:51PM +0300, Alexander Popov wrote: >> On 27.07.2019 00:09, Alexander Popov wrote: >>> On 26.07.2019 2:25:03 GMT+02:00, John Snow wrote: Oh, this is fun. >>> ... I can worry about a proper fix for 4.2+. >>>

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Michael S. Tsirkin
On Wed, Nov 06, 2019 at 01:17:51PM +0300, Alexander Popov wrote: > On 27.07.2019 00:09, Alexander Popov wrote: > > On 26.07.2019 2:25:03 GMT+02:00, John Snow wrote: > >> Oh, this is fun. > > ... > >> I can worry about a proper fix for 4.2+. > > > > Hello John, > > > > Thanks for your letter. > >

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Michael S. Tsirkin
On Thu, Jul 25, 2019 at 08:25:03PM -0400, John Snow wrote: > > > On 7/5/19 10:07 AM, Alexander Popov wrote: > > This assertion was introduced in the commit a718978ed58a in July 2015. > > It implies that the size of successful DMA transfers handled in > > ide_dma_cb() should be multiple of 512

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Alexander Popov
On 27.07.2019 00:09, Alexander Popov wrote: > On 26.07.2019 2:25:03 GMT+02:00, John Snow wrote: >> Oh, this is fun. > ... >> I can worry about a proper fix for 4.2+. > > Hello John, > > Thanks for your letter. > > I double-checked the git history and mailing list, I'm still sure > that my fix for

Re: [Qemu-block] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-26 Thread Alexander Popov
26 июля 2019 г. 2:25:03 GMT+02:00, John Snow пишет: >Oh, this is fun. ... >I can worry about a proper fix for 4.2+. Hello John, Thanks for your letter. I double-checked the git history and mailing list, I'm still sure that my fix for this assertion is correct. You know this code very

Re: [Qemu-block] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-25 Thread John Snow
On 7/5/19 10:07 AM, Alexander Popov wrote: > This assertion was introduced in the commit a718978ed58a in July 2015. > It implies that the size of successful DMA transfers handled in > ide_dma_cb() should be multiple of 512 (the size of a sector). > > But guest systems can initiate DMA

Re: [Qemu-block] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-16 Thread P J P
+-- On Tue, 16 Jul 2019, John Snow wrote --+ | I also feel that a privileged DOS by a guest of a legacy device is actually | low priority security-wise, unless we can demonstrate that there are side | effects that can be exploited. Right, we are not treating this as a CVE issue as is.

Re: [Qemu-block] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-16 Thread John Snow
On 7/16/19 7:25 AM, Kevin Wolf wrote: > Am 15.07.2019 um 13:24 hat Alexander Popov geschrieben: >> On 05.07.2019 17:07, Alexander Popov wrote: >>> This assertion was introduced in the commit a718978ed58a in July 2015. >>> It implies that the size of successful DMA transfers handled in >>>

Re: [Qemu-block] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-16 Thread Kevin Wolf
Am 15.07.2019 um 13:24 hat Alexander Popov geschrieben: > On 05.07.2019 17:07, Alexander Popov wrote: > > This assertion was introduced in the commit a718978ed58a in July 2015. > > It implies that the size of successful DMA transfers handled in > > ide_dma_cb() should be multiple of 512 (the size

Re: [Qemu-block] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-15 Thread Alexander Popov
On 05.07.2019 17:07, Alexander Popov wrote: > This assertion was introduced in the commit a718978ed58a in July 2015. > It implies that the size of successful DMA transfers handled in > ide_dma_cb() should be multiple of 512 (the size of a sector). > > But guest systems can initiate DMA transfers

Re: [Qemu-block] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-05 Thread Alexander Popov
On 05.07.2019 17:07, Alexander Popov wrote: > This assertion was introduced in the commit a718978ed58a in July 2015. > It implies that the size of successful DMA transfers handled in > ide_dma_cb() should be multiple of 512 (the size of a sector). > > But guest systems can initiate DMA transfers

[Qemu-block] [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-07-05 Thread Alexander Popov
This assertion was introduced in the commit a718978ed58a in July 2015. It implies that the size of successful DMA transfers handled in ide_dma_cb() should be multiple of 512 (the size of a sector). But guest systems can initiate DMA transfers that don't fit this requirement. Let's improve the