Re: [Qemu-block] [PATCH] block/iscsi: add support for request timeouts

2015-06-26 Thread Paolo Bonzini
On 25/06/2015 23:21, Peter Lieven wrote: I will send a v2 that is compatible with 1.9.0 and enables the timeout stuff only for libiscsi = 1.15.0 Since Stefan has already applied the patch, restoring 1.9.0 compatibility (and disabling timeouts between 1.9.0 and 1.14.x) on top of this patch

Re: [Qemu-block] [PATCH] block/iscsi: add support for request timeouts

2015-06-25 Thread Stefan Hajnoczi
On Tue, Jun 16, 2015 at 01:45:07PM +0200, Peter Lieven wrote: libiscsi starting with 1.15 will properly support timeout of iscsi commands. The default will remain no timeout, but this can be changed via cmdline parameters, e.g.: qemu -iscsi timeout=30 -drive file=iscsi://... If a timeout

Re: [Qemu-block] [PATCH] block/iscsi: add support for request timeouts

2015-06-25 Thread Peter Lieven
Am 25.06.2015 um 23:08 schrieb Paolo Bonzini: On 16/06/2015 13:45, Peter Lieven wrote: libiscsi starting with 1.15 will properly support timeout of iscsi commands. The default will remain no timeout, but this can be changed via cmdline parameters, e.g.: qemu -iscsi timeout=30 -drive

Re: [Qemu-block] [PATCH] block/iscsi: add support for request timeouts

2015-06-25 Thread Peter Lieven
Am 23.06.2015 um 01:03 schrieb ronnie sahlberg: LGTM It is good to finally have timeouts that work in libiscsi, and a consumer that can use and benefit from it. Paolo, Kevin, Stefan, do you think this is sth for 2.4? Peter

Re: [Qemu-block] [PATCH] block/iscsi: add support for request timeouts

2015-06-22 Thread ronnie sahlberg
LGTM It is good to finally have timeouts that work in libiscsi, and a consumer that can use and benefit from it. On Tue, Jun 16, 2015 at 4:45 AM, Peter Lieven p...@kamp.de wrote: libiscsi starting with 1.15 will properly support timeout of iscsi commands. The default will remain no timeout,