Re: [Qemu-block] [PATCH] quorum: Only compile when supported

2016-07-04 Thread Alberto Garcia
On Sat 02 Jul 2016 02:36:38 PM CEST, Max Reitz wrote: >> This was the only exceptional module init function that does >> something else than a simple list of bdrv_register() calls, in all >> the block drivers. > > This sounds like this patch specifically wants to drop the check from >

Re: [Qemu-block] [PATCH] quorum: Only compile when supported

2016-07-02 Thread Max Reitz
On 28.06.2016 03:47, Fam Zheng wrote: > This was the only exceptional module init function that does something > else than a simple list of bdrv_register() calls, in all the block > drivers. This sounds like this patch specifically wants to drop the check from bdrv_quorum_init(). I think keeping

Re: [Qemu-block] [PATCH] quorum: Only compile when supported

2016-06-28 Thread Alberto Garcia
On Tue 28 Jun 2016 03:47:47 AM CEST, Fam Zheng wrote: > The qcrypto_hash_supports is actually a static check, determined at > compile time. Follow the block-job-$(CONFIG_FOO) convention for > consistency. > > Signed-off-by: Fam Zheng Oh, so we didn't see this