Re: [Qemu-block] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

2017-09-20 Thread Alberto Garcia
On Tue 19 Sep 2017 05:50:25 PM CEST, Stefan Hajnoczi wrote: > Clear tg->any_timer_armed[] when throttling timers are destroy during > AioContext attach/detach. Failure to do so causes throttling to hang > because we believe the timer is already scheduled! > > The following was broken at least

[Qemu-block] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

2017-09-19 Thread Stefan Hajnoczi
Clear tg->any_timer_armed[] when throttling timers are destroy during AioContext attach/detach. Failure to do so causes throttling to hang because we believe the timer is already scheduled! The following was broken at least since QEMU 2.10.0 with -drive iops=100: $ dd if=/dev/zero of=/dev/vdb