Re: [Qemu-block] [PATCH] virtio-blk: Drop x-data-plane option

2015-12-08 Thread Stefan Hajnoczi
On Mon, Dec 07, 2015 at 05:10:26PM +, Peter Maydell wrote: > On 7 December 2015 at 15:19, Paolo Bonzini wrote: > > > > > > On 07/12/2015 14:02, Fam Zheng wrote: > >> On Mon, 12/07 12:29, Cornelia Huck wrote: > >>> On Mon, 7 Dec 2015 18:59:27 +0800 > >>> Fam Zheng

Re: [Qemu-block] [PATCH] virtio-blk: Drop x-data-plane option

2015-12-07 Thread Cornelia Huck
On Mon, 7 Dec 2015 16:19:07 +0100 Paolo Bonzini wrote: > The solution would be to add object_property_add_child to > virtio_blk_data_plane_create, between object_initialize and > user_creatable_complete. But I think this patch is ok for 2.5. Just sent a patch that does

Re: [Qemu-block] [PATCH] virtio-blk: Drop x-data-plane option

2015-12-07 Thread Paolo Bonzini
On 07/12/2015 14:02, Fam Zheng wrote: > On Mon, 12/07 12:29, Cornelia Huck wrote: >> On Mon, 7 Dec 2015 18:59:27 +0800 >> Fam Zheng wrote: >> >>> The official way of enabling dataplane is through the "iothread" >>> property that references an iothread object created by

Re: [Qemu-block] [PATCH] virtio-blk: Drop x-data-plane option

2015-12-07 Thread Peter Maydell
On 7 December 2015 at 15:19, Paolo Bonzini wrote: > > > On 07/12/2015 14:02, Fam Zheng wrote: >> On Mon, 12/07 12:29, Cornelia Huck wrote: >>> On Mon, 7 Dec 2015 18:59:27 +0800 >>> Fam Zheng wrote: >>> The official way of enabling dataplane is through

[Qemu-block] [PATCH] virtio-blk: Drop x-data-plane option

2015-12-07 Thread Fam Zheng
The official way of enabling dataplane is through the "iothread" property that references an iothread object created by "-object iothread". Since the old "x-data-plane=on" way now even crashes, it's probably easier to just drop it: $ qemu-system-x86_64 -drive file=null-co://,id=d0,if=none \