Re: [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-02-01 Thread Stefan Hajnoczi
On Tue, Jan 30, 2018 at 04:56:12PM +0100, Kevin Wolf wrote: > Am 30.01.2018 um 13:38 hat Stefan Hajnoczi geschrieben: > > On Mon, Jan 29, 2018 at 04:41:07PM +0100, Kevin Wolf wrote: > > > Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: > > > > On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark

Re: [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-02-01 Thread Stefan Hajnoczi
On Mon, Jan 29, 2018 at 10:13:02AM -0600, Mark Kanda wrote: > > > On 1/29/2018 9:41 AM, Kevin Wolf wrote: > > Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: > > > On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: > > > > Add a BlockDriverState NULL check to virtio_blk_handle_re

Re: [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-30 Thread John Snow
On 01/30/2018 10:56 AM, Kevin Wolf wrote: > Am 30.01.2018 um 13:38 hat Stefan Hajnoczi geschrieben: >> On Mon, Jan 29, 2018 at 04:41:07PM +0100, Kevin Wolf wrote: >>> Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: > Add

Re: [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-30 Thread Kevin Wolf
Am 30.01.2018 um 13:38 hat Stefan Hajnoczi geschrieben: > On Mon, Jan 29, 2018 at 04:41:07PM +0100, Kevin Wolf wrote: > > Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: > > > On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: > > > > Add a BlockDriverState NULL check to virtio_blk

Re: [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-30 Thread Stefan Hajnoczi
On Mon, Jan 29, 2018 at 04:41:07PM +0100, Kevin Wolf wrote: > Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: > > On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: > > > Add a BlockDriverState NULL check to virtio_blk_handle_request() > > > to prevent a segfault if the drive is fo

Re: [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-29 Thread Mark Kanda
On 1/29/2018 9:41 AM, Kevin Wolf wrote: Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: Add a BlockDriverState NULL check to virtio_blk_handle_request() to prevent a segfault if the drive is forcibly removed using HMP 'drive_

Re: [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-29 Thread Kevin Wolf
Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: > On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: > > Add a BlockDriverState NULL check to virtio_blk_handle_request() > > to prevent a segfault if the drive is forcibly removed using HMP > > 'drive_del' (without performing a hotpl

Re: [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-24 Thread Stefan Hajnoczi
On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: > Add a BlockDriverState NULL check to virtio_blk_handle_request() > to prevent a segfault if the drive is forcibly removed using HMP > 'drive_del' (without performing a hotplug 'device_del' first). > > Signed-off-by: Mark Kanda > Review

[Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-22 Thread Mark Kanda
Add a BlockDriverState NULL check to virtio_blk_handle_request() to prevent a segfault if the drive is forcibly removed using HMP 'drive_del' (without performing a hotplug 'device_del' first). Signed-off-by: Mark Kanda Reviewed-by: Karl Heubaum Reviewed-by: Ameya More --- hw/block/virtio-blk.c