Re: [Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-04-15 Thread Max Reitz
On 11.04.19 12:43, Sam Eiderman wrote: > Are you going to fix this when you apply the patch or should I? I can’t fix it because Kevin has applied this patch to his branch. I’d prefer it if there weren’t commits that break patches (even if it’s just temporary), so I think right now it’s mostly up

Re: [Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-04-11 Thread Sam Eiderman
Are you going to fix this when you apply the patch or should I? > On 10 Apr 2019, at 23:07, Max Reitz wrote: > > On 10.04.19 21:15, Max Reitz wrote: >> On 26.03.19 20:58, Sam Eiderman wrote: >>> Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed >>> the probe function to c

Re: [Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-04-10 Thread Max Reitz
On 10.04.19 21:15, Max Reitz wrote: > On 26.03.19 20:58, Sam Eiderman wrote: >> Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed >> the probe function to correctly guess vmdk descriptors with version=3. >> >> This solves the issue where vmdk snapshot with parent vmdk descri

Re: [Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-04-10 Thread Max Reitz
On 26.03.19 20:58, Sam Eiderman wrote: > Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed > the probe function to correctly guess vmdk descriptors with version=3. > > This solves the issue where vmdk snapshot with parent vmdk descriptor > containing "version=3" would be tr

Re: [Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-03-28 Thread Kevin Wolf
Am 26.03.2019 um 20:58 hat Sam Eiderman geschrieben: > Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed > the probe function to correctly guess vmdk descriptors with version=3. > > This solves the issue where vmdk snapshot with parent vmdk descriptor > containing "version=

Re: [Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-03-27 Thread Fam Zheng
On Tue, 03/26 21:58, Sam Eiderman wrote: > Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed > the probe function to correctly guess vmdk descriptors with version=3. > > This solves the issue where vmdk snapshot with parent vmdk descriptor > containing "version=3" would be

Re: [Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-03-27 Thread Sam Eiderman
Thanks, Also please notice that the mentioned commit in the commit message has it’s commit id changed to b69864e. Sam > On 27 Mar 2019, at 2:35, Eric Blake wrote: > > On 3/26/19 2:58 PM, Sam Eiderman wrote: >> Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed >> the pr

Re: [Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-03-26 Thread Eric Blake
On 3/26/19 2:58 PM, Sam Eiderman wrote: > Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed > the probe function to correctly guess vmdk descriptors with version=3. All patches need to cc qemu-devel in addition to their maintainers (I've added that now). > > This solves t

[Qemu-block] [PATCH] vmdk: Set vmdk parent backing_format to vmdk

2019-03-26 Thread Sam Eiderman
Commit fb2105b ("vmdk: Support version=3 in VMDK descriptor files") fixed the probe function to correctly guess vmdk descriptors with version=3. This solves the issue where vmdk snapshot with parent vmdk descriptor containing "version=3" would be treated as raw instead vmdk. In the future case wh