Re: [Qemu-block] [PATCH 08/13] tests: Add qdict_stringify_for_keyval() test

2018-05-11 Thread Eric Blake
On 05/11/2018 01:13 PM, Max Reitz wrote: + * "h": 0x, + * "i": true, + * "j": 0 Is it worth testing fun things like '-0.0'? Sure, why not. Maybe even infinity, although I'm not quite sure the input visitor can handle it... JSON can't handle Inf or N

Re: [Qemu-block] [PATCH 08/13] tests: Add qdict_stringify_for_keyval() test

2018-05-11 Thread Max Reitz
On 2018-05-10 18:02, Eric Blake wrote: > On 05/09/2018 11:55 AM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >>   tests/check-qdict.c | 54 >> + >>   1 file changed, 54 insertions(+) >> > >> +static void qdict_stringify_for_keyval_test(vo

Re: [Qemu-block] [PATCH 08/13] tests: Add qdict_stringify_for_keyval() test

2018-05-10 Thread Eric Blake
On 05/09/2018 11:55 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/check-qdict.c | 54 + 1 file changed, 54 insertions(+) +static void qdict_stringify_for_keyval_test(void) +{ +QDict *dict = qdict_new(); + +/* + * Te

[Qemu-block] [PATCH 08/13] tests: Add qdict_stringify_for_keyval() test

2018-05-09 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/check-qdict.c | 54 + 1 file changed, 54 insertions(+) diff --git a/tests/check-qdict.c b/tests/check-qdict.c index 93e2112b6d..ef5d17f815 100644 --- a/tests/check-qdict.c +++ b/tests/check-qdict.c @@ -973,6 +