Re: [Qemu-block] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-30 Thread Jeff Cody
On Wed, Jun 22, 2016 at 03:35:27PM +0300, Denis V. Lunev wrote: > There are 2 deficiencies here: > - mirror_iteration could start several requests inside. Thus we could > simply have more in_flight requests than MAX_IN_FLIGHT. > - keeping this in mind throttling in mirror_run which is checking >

Re: [Qemu-block] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-30 Thread Jeff Cody
On Wed, Jun 22, 2016 at 03:35:27PM +0300, Denis V. Lunev wrote: > There are 2 deficiencies here: > - mirror_iteration could start several requests inside. Thus we could > simply have more in_flight requests than MAX_IN_FLIGHT. > - keeping this in mind throttling in mirror_run which is checking >

Re: [Qemu-block] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-29 Thread Max Reitz
On 22.06.2016 14:35, Denis V. Lunev wrote: > There are 2 deficiencies here: > - mirror_iteration could start several requests inside. Thus we could > simply have more in_flight requests than MAX_IN_FLIGHT. > - keeping this in mind throttling in mirror_run which is checking > s->in_flight ==

Re: [Qemu-block] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-29 Thread Denis V. Lunev
On 06/29/2016 07:08 PM, Max Reitz wrote: On 22.06.2016 14:35, Denis V. Lunev wrote: There are 2 deficiencies here: - mirror_iteration could start several requests inside. Thus we could simply have more in_flight requests than MAX_IN_FLIGHT. - keeping this in mind throttling in mirror_run

Re: [Qemu-block] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-28 Thread Denis V. Lunev
On 06/22/2016 03:35 PM, Denis V. Lunev wrote: There are 2 deficiencies here: - mirror_iteration could start several requests inside. Thus we could simply have more in_flight requests than MAX_IN_FLIGHT. - keeping this in mind throttling in mirror_run which is checking s->in_flight ==

[Qemu-block] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-22 Thread Denis V. Lunev
There are 2 deficiencies here: - mirror_iteration could start several requests inside. Thus we could simply have more in_flight requests than MAX_IN_FLIGHT. - keeping this in mind throttling in mirror_run which is checking s->in_flight == MAX_IN_FLIGHT is wrong. The patch adds the check and