Re: [Qemu-block] [PATCH 16/17] block: protect modification of dirty bitmaps with a mutex

2017-05-08 Thread Stefan Hajnoczi
On Fri, May 05, 2017 at 12:47:35PM +0200, Paolo Bonzini wrote: > > > On 05/05/2017 12:36, Stefan Hajnoczi wrote: > > On Thu, Apr 20, 2017 at 02:00:57PM +0200, Paolo Bonzini wrote: > >> @@ -410,6 +442,18 @@ int bdrv_get_dirty(BlockDriverState *bs, > >> BdrvDirtyBitmap *bitmap, > >> } > >>

Re: [Qemu-block] [PATCH 16/17] block: protect modification of dirty bitmaps with a mutex

2017-05-05 Thread Paolo Bonzini
On 05/05/2017 12:36, Stefan Hajnoczi wrote: > On Thu, Apr 20, 2017 at 02:00:57PM +0200, Paolo Bonzini wrote: >> @@ -410,6 +442,18 @@ int bdrv_get_dirty(BlockDriverState *bs, >> BdrvDirtyBitmap *bitmap, >> } >> } >> >> +int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, >>

Re: [Qemu-block] [PATCH 16/17] block: protect modification of dirty bitmaps with a mutex

2017-05-05 Thread Stefan Hajnoczi
On Thu, Apr 20, 2017 at 02:00:57PM +0200, Paolo Bonzini wrote: > @@ -410,6 +442,18 @@ int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap > *bitmap, > } > } > > +int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, > + int64_t sector) Is it a good idea

[Qemu-block] [PATCH 16/17] block: protect modification of dirty bitmaps with a mutex

2017-04-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/dirty-bitmap.c | 74 +--- block/mirror.c | 11 +-- include/block/block_int.h| 4 +-- include/block/dirty-bitmap.h | 23 +++--- 4 files changed, 97